Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Git Sync): discard changes should delete requests and other entities if they don't exist in the previous version #8551

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Mar 31, 2025

The issue:

Inside a Git Project, when a user creates a request in a file and then discards the changes that have been made in that file, any entities e.g. new request that were created are not properly removed from the db.
This means that a user will chose to discard changes but those changes will persist.

Highlights:

  • When git updates a file we clean the previous workspace and it's descendants and use the resources provided by that version of the file.

Closes INS-5245

@gatzjames gatzjames requested a review from a team March 31, 2025 10:30
@gatzjames gatzjames self-assigned this Mar 31, 2025
Copy link
Contributor

@pavkout pavkout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatzjames gatzjames merged commit 8d898da into Kong:develop Mar 31, 2025
9 checks passed
@gatzjames gatzjames deleted the fix/git-sync-undo-changes branch March 31, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants