Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Export globals paramter in Run via CLI if user has selected any global environment #8559

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

cwangsmv
Copy link
Contributor

@cwangsmv cwangsmv commented Apr 1, 2025

Changes
Fix the issue that when user activates any global environment, Run Via CLI has not exported the globals Inso parameter.
Screenshot 2025-03-31 at 17 37 27

Currently, if user has selected any global environment and click Run Via CLI, the selected global environment will not be exposed in CLI preview.
As a result, Inso will use the active global environment in the workspace. But if user has selected other global environment in the current workspace later, the active global environment will be changed. This will make the environment context different from what user is expecting.
Fix this issue by expose active global environment parameter together.

@cwangsmv cwangsmv requested review from jackkav and ihexxa April 1, 2025 02:17
@cwangsmv cwangsmv force-pushed the fix/inso-run-via-cli-global-not-exported branch from 1dee6b6 to 720b654 Compare April 1, 2025 07:16
@cwangsmv cwangsmv enabled auto-merge (squash) April 1, 2025 07:16
@cwangsmv cwangsmv merged commit d69d08e into develop Apr 1, 2025
9 checks passed
@cwangsmv cwangsmv deleted the fix/inso-run-via-cli-global-not-exported branch April 1, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants