Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return values of basic-auth.access:retrieve_credentials #14389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steveoliver
Copy link

@steveoliver steveoliver commented Apr 2, 2025

Update the docblock of basic-auth.access:retrieve_credentials to reflect the username and password values returned.

Summary

Checklist

  • The Pull Request has tests (N/A?)
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE (N/A?)

Issue reference

Fix #[issue number]

Update the docblock of basic-auth.access:retrieve_credentials to reflect the username and password values returned.
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@steveoliver steveoliver changed the title Update @return values of basic-auth.access:retrieve_credentials Update return values of basic-auth.access:retrieve_credentials Apr 2, 2025
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants