feat: define konnect transit gateway #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
from
0873db3 to
2c79dbf
Compare
pmalek
reviewed
Apr 2, 2025
api/konnect/v1alpha1/konnect_cloudgateway_transitgateway_types.go
Outdated
Show resolved
Hide resolved
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
3 times, most recently
from
8dd0a61 to
9d684eb
Compare
pmalek
reviewed
Apr 3, 2025
api/konnect/v1alpha1/konnect_cloudgateway_transitgateway_types.go
Outdated
Show resolved
Hide resolved
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
from
91fa75f to
6a740e9
Compare
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
from
6a740e9 to
9312dd4
Compare
pmalek
reviewed
Apr 9, 2025
test/crdsvalidation/konnect.konghq.com/konnectcloudgatewaytransitgateway_test.go
Show resolved
Hide resolved
test/crdsvalidation/konnect.konghq.com/konnectcloudgatewaytransitgateway_test.go
Outdated
Show resolved
Hide resolved
api/konnect/v1alpha1/konnect_cloudgateway_transitgateway_types.go
Outdated
Show resolved
Hide resolved
api/konnect/v1alpha1/konnect_cloudgateway_transitgateway_types.go
Outdated
Show resolved
Hide resolved
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
from
edf11ee to
0680a28
Compare
pmalek
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Can we add a sample manifest - https://github.com/Kong/kubernetes-configuration/tree/main/config/samples - to this PR?
This - apart from serving a purpose of being informative - also ensures that these actually works (through test.samples on CI).
api/konnect/v1alpha1/konnect_cloudgateway_transitgateway_types.go
Outdated
Show resolved
Hide resolved
Done. Added a sample. |
randmonkey
force-pushed
the
feat/define_konnect_transit_gateway
branch
from
0680a28 to
0ac9034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Define
KonnectCloudGatewayTransitGatewayCRD to describe a Konnect transit gateway:Konnect transit gatesay
Which issue this PR fixes
Fixes #312
Special notes for your reviewer:
Todo:
Get***andSet***methods to implement interfaces used in KGOPR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes