Skip to content

Generate fields for markers in REPL so compiler plugin can extract the schema #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

koperagen
Copy link
Collaborator

without this change plugin cannot see schemas from previous cells, generated by REPL:

val df = DataFrame.read("...")
%%
val df1 = df.add("a") { 42 } 
// only df1.a is available here, because from plugin POV df has empty schema

After this PR generated markers (DataFrame<T>) will have unified structure, so schema can be extracted from both REPL and plugin generated ones

@koperagen koperagen requested a review from zaleslaw April 28, 2025 12:20
@koperagen koperagen self-assigned this Apr 28, 2025
@koperagen koperagen added this to the 1.0.0-Beta1 (0.16) milestone Apr 29, 2025
@koperagen koperagen added the Compiler plugin Anything related to the DataFrame Compiler Plugin label Apr 29, 2025
@koperagen koperagen force-pushed the supertypes-codegen-issue-repro branch from d48cdd9 to aa0aed2 Compare May 8, 2025 23:08
@koperagen koperagen force-pushed the supertypes-codegen-issue-repro branch from aa0aed2 to 28f202b Compare May 8, 2025 23:09
@koperagen koperagen merged commit cfbc3c5 into master May 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler plugin Anything related to the DataFrame Compiler Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants