Set and map collisions optimization #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qurbonzoda
force-pushed
the
set-and-map-collisions-optimization
branch
from
89f6700 to
6b0db5e
Compare
|
Also addresses #45. |
qurbonzoda
force-pushed
the
set-and-map-collisions-optimization
branch
from
6b0db5e to
44f49db
Compare
|
Let's try to eliminate asymptotic overhead on big sets/maps. For example, given the current representation of a collision node, I believe |
added 6 commits
October 4, 2019 09:49
qurbonzoda
force-pushed
the
set-and-map-collisions-optimization
branch
from
1963e00 to
d7ccdc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark parameters adjustment and benchmark result files will be removed before merging.
Introducing
CollisionTrieNodefor collision nodes (polymorphism approach) adds significant performance losses, see hashSet regressions: https://teamcity.jetbrains.com/viewLog.html?buildId=2469110&buildTypeId=KotlinTools_KotlinxCollectionsImmutable_BenchmarkHashIterations&tab=artifacts#%2FbenchmarkResultsThus, collision nodes and normal nodes were not separated into different entities.
Final benchmark results: https://teamcity.jetbrains.com/viewLog.html?buildId=2469130&buildTypeId=KotlinTools_KotlinxCollectionsImmutable_BenchmarkHashIterations&tab=artifacts