Skip to content

Append #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Append #13

wants to merge 1 commit into from

Conversation

VuCuongHD96
Copy link

No description provided.

KyoheiG3
KyoheiG3 reviewed Sep 9, 2021
View reviewed changes
Copy link
Owner

@KyoheiG3 KyoheiG3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VuCuongHD96
Can you remove any debug print?

GridView/GridView.swift
Comment on lines -772 to -773
let horizontal = Horizontal(x: size.width, width: widthForColumn)
columnHorizontals.append(horizontal)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyoheiG3 KyoheiG3 KyoheiG3 left review comments

+1 more reviewer

@pokhachevskiy pokhachevskiy pokhachevskiy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VuCuongHD96 @KyoheiG3 @pokhachevskiy