feature/custom themes #1396
Merged
feature/custom themes #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGUG2Z
force-pushed
the
feature/custom-themes
branch
2 times, most recently
from
d8e6897 to
4968b0f
Compare
LGUG2Z
force-pushed
the
feature/custom-themes
branch
from
c395d26 to
2427398
Compare
|
Changed the target branch to |
alex-ds13
force-pushed
the
feature/custom-themes
branch
from
2427398 to
afff346
Compare
This commit changes the border manager notification to an enum that can be a `Notification::Update(Option<isize>)` which should work like before or a `Notification::ForceUpdate` which will always update the borders and it will also update the border's brushes. To do so, this commit moved the brush creation from the `create()` function to a new `update_brushes` function on the `Border` itself and it changed the `Border` `render_target` from a `OnceLock` to an `Option<RenderTarget>` so that we can always change it when we need to. This commit also adds a new function called `send_force_update()` to the border manager to make it easier to send this notification. This commit also added a check for `force_update_borders` on the `process_command` function so that any command that reloads the configuration, changes the theme or changes any border config can set it to `true`. When this is true we send the `ForceUpdate` notification, if false we send the normal `Update` notification as before. The theme manager now always sends the `ForceUpdate` notification to the border manager. This commit adds a new function to the window manager called `apply_wallpaper_for_monitor_workspace` which in turn calls the `apply_wallpaper` function for the workspace specified with the `monitor_idx` and `workspace_idx` given (if the workspace in question doesn't have a wallpaper defined this won't do anything). All these changes make it so the wallpaper theme generation colors are properly applied in all situations.
This commit adds the option to set `Wallpaper` per monitor. When changing workspaces it will first check for a workspace wallpaper, if there is none it then checks for a monitor wallpaper.
alex-ds13
force-pushed
the
feature/custom-themes
branch
from
afff346 to
7203325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wallpaperto a newWallpaperwith that path andgenerate_themeset tofalsegenerate_themebehaves as if it wasfalseby default, since if you don't set it on the workspace nor on the monitor it will use the default one from the start which isfalse