Refactor opengl examples to reduce code duplication and fix warnings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpdigest
force-pushed
the
master
branch
4 times, most recently
from
a0522f3 to
3774f7b
Compare
httpdigest
force-pushed
the
master
branch
9 times, most recently
from
0dfe4d5 to
1a4879c
Compare
httpdigest
force-pushed
the
master
branch
15 times, most recently
from
aa57aae to
1a7f824
Compare
httpdigest
force-pushed
the
main
branch
11 times, most recently
from
f5eb99a to
5149b90
Compare
httpdigest
force-pushed
the
main
branch
2 times, most recently
from
4131b94 to
3ef47ae
Compare
httpdigest
force-pushed
the
main
branch
3 times, most recently
from
6127460 to
6717e49
Compare
httpdigest
force-pushed
the
main
branch
10 times, most recently
from
eafcf00 to
492ad16
Compare
httpdigest
force-pushed
the
main
branch
2 times, most recently
from
86d8b54 to
bdb5675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glancing over the opengl examples I found a lot of warnings and bad practices: code duplication, non-private fields and various inconsistencies.
I'd like to propose some simple refactorings to clean up the examples. After all, the examples are probably the first thing new developers see.
This pull request is not complete, but I would like to have some feedback on the proposal. The
ImmediateModeDemoandNoVerticesBSplineDemohave been refactored as examples. The glfw scaffolding (which is duplicated among all examples) has been extracted into a parent class, so that each example only contains logic and state relevant for the example.