Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (lld): Support DMK inside LLD #8807

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Jan 6, 2025

  • πŸ”§ (build): Update our tsconfig to use nodenext or bundler
  • ✨ (lld): use dmk listenToKnownDevices in LLD
  • ✨(live-dmk): Update DMK to support synconboarding

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

DMK Integration

Update useListenToHidDevices to be able to rely on the DMK listenToKnownDevices() when the feature flag is on.
Also update the way we register the transports so everything is available at any time (but the open on the LiveDMKTransport only works when FF is on)

NodeNext migration notes

  • coin-solana => turned off the cjs build used node10 to build cjs (ts config)
  • coin-filecoin => turned off the cjs build used node10 to build cjs (ts config)
  • coin-bitcoin => bs58check needs an update (2.0.2 => 4.0.0) / added types.d.ts
  • coin-hedera => bumped @hashgraph/sdk to 2.54.2 and turned off cjs builds used node10 to build cjs (ts config)
  • coin-polkadot => turned off cjs build used node10 to build cjs (ts config)
  • coin-framework => https://github.com/axic/bip32-path 8 YEARS OLD 😱 / fixed type

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@valpinkman valpinkman requested review from a team as code owners January 6, 2025 10:40
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 17, 2025 4:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 4:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 4:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 4:15pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Jan 6, 2025
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 6972225 to 75f4b85 Compare January 6, 2025 11:09
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 6, 2025

Desktop Bundle Checks

Comparing 9198e69 against 91bb3fa.

⚠️ main bundle size significantly increased: 1.8mb -> 2.3mb. Please check if this is expected.
πŸš€ renderer bundle size decreased (38mb -> 37.8mb). Thanks ❀️
⚠️ semver library is now duplicated in main (regression)
⚠️ @sentry/utils library is now duplicated in main (regression)
⚠️ @ledgerhq/logs library is now duplicated in main (regression)
⚠️ ws library is now duplicated in main (regression)
⚠️ uuid library is now duplicated in main (regression)

Mobile Bundle Checks

Comparing 4f8be62 against a8e2a6d.

πŸš€ main.ios.jsbundle bundle size decreased (62mb -> 61.9mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (62mb -> 61.9mb). Thanks ❀️

@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 75f4b85 to 25adf17 Compare January 7, 2025 17:05
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 25adf17 to 47cbc26 Compare January 8, 2025 09:34
@valpinkman valpinkman changed the title feat: Use listenToKnownDevices from DMK ✨ (lld): Support DMK inside LLD Jan 8, 2025
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 47cbc26 to cdae883 Compare January 8, 2025 18:06
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from cdae883 to 089b503 Compare January 9, 2025 08:08
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 089b503 to 50744aa Compare January 9, 2025 08:34
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 50744aa to 69f2e4b Compare January 9, 2025 08:38
KVNLS
KVNLS previously approved these changes Jan 17, 2025
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

Justkant
Justkant previously approved these changes Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM tools Has changes in tools ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants