✨ (llm) [LIVE-14839]: As a user when I start the onboarding I want to get a generic pairing message #8823
+82
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
jdabbech-ledger
force-pushed
the
feat/live-14839-connect-device-rm-nano-screen
branch
7 times, most recently
from
adf1195 to
202e3ce
Compare
jdabbech-ledger
force-pushed
the
feat/live-14839-connect-device-rm-nano-screen
branch
6 times, most recently
from
968d7a3 to
b98f0a7
Compare
ypolishchuk-ledger
previously approved these changes
Jan 17, 2025
themooneer
reviewed
Jan 17, 2025
| @@ -316,6 +316,8 @@ export default function SelectDevice({ | |||
| retryRequestOnIssue={retryRequestOnIssue} | |||
| cannotRetryRequest={cannotRetryRequest} | |||
| /> | |||
| {/* @Fixme Render a hidden text element to render screen correctly on ios sim release for e2e test */} | |||
| <Text style={{ height: 0 }}>{"Hidden text element to satisfy detox ios release"}</Text> | |||
There was a problem hiding this comment.
maybe with an opacity:0 + the height:0 to prevent any uncontrolled UI glitch
themooneer
reviewed
Jan 17, 2025
.changeset/brave-icons-glow.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "live-mobile": patch | |||
There was a problem hiding this comment.
no patch please, set it to minor
jdabbech-ledger
force-pushed
the
feat/live-14839-connect-device-rm-nano-screen
branch
from
b98f0a7 to
73913b6
Compare
abdurrahman-ledger
approved these changes
Jan 17, 2025
cgrellard-ledger
approved these changes
Jan 17, 2025
themooneer
approved these changes
Jan 17, 2025
jdabbech-ledger
deleted the
feat/live-14839-connect-device-rm-nano-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Remove default nanoX pairing screen
❓ Context
🧐 Checklist for the PR Reviewers