Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ DMK Eth Signer integration #8931

Open
wants to merge 11 commits into
base: feat/dsdk-508-listen-known-devices
Choose a base branch
from

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Jan 16, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add @ledgerhq/device-signer-kit-ethereum integration with the DMK transport.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@aussedatlo aussedatlo requested review from a team as code owners January 16, 2025 17:14
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:25am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:25am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:25am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:25am

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jan 16, 2025
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 72a7e5f to 693e0d2 Compare January 16, 2025 17:15
@valpinkman valpinkman requested a review from a team as a code owner January 16, 2025 17:15
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 16, 2025

Desktop Bundle Checks

Comparing 2154973 against bbb8961.

🚀 renderer bundle size decreased (38mb -> 37.8mb). Thanks ❤️
⚠️ ethers library is now duplicated in renderer (regression)
🚀 superstruct library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 2154973 against bbb8961.

⚠️ main.ios.jsbundle bundle size significantly increased: 62mb -> 62.8mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 62mb -> 62.8mb. Please check if this is expected.

@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch from 693e0d2 to f9380f2 Compare January 17, 2025 10:42
@valpinkman valpinkman requested review from a team as code owners January 17, 2025 10:42
@valpinkman valpinkman force-pushed the feat/dsdk-508-listen-known-devices branch 4 times, most recently from bd3d149 to 541dc53 Compare January 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants