Implement GRANDPA-GHOST #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Closed
Zurcusa
approved these changes
Jan 3, 2025
| @Log | ||
| @Component | ||
| public class GrandpaService { | ||
| private final GrandpaState grandpaState; |
There was a problem hiding this comment.
Suggested change
| private final GrandpaState grandpaState; | |
| private final GrandpaState grandpaState; |
| * | ||
| * @return GRANDPA GHOST block as a vote | ||
| */ | ||
| public Vote getGrandpaGHOST() { |
There was a problem hiding this comment.
Suggested change
| public Vote getGrandpaGHOST() { | |
| public Vote getGrandpaGhost() { |
Just a personal pref, but I'd rather stick to the naming conventions unless absolutely necessary.
| Map<Hash256, BigInteger> blocks = getPossibleSelectedBlocks(threshold, Subround.PRE_VOTE); | ||
|
|
||
| if (blocks.isEmpty() || threshold.equals(BigInteger.ZERO)) { | ||
| throw new ExecutionFailedException("GHOST not found"); |
There was a problem hiding this comment.
It would be a good idea to have a custom exception for grandpa/ghost related manners. GrandpaGenericException GhostExecutionException ?
There was a problem hiding this comment.
I suggest we reuse the existing Subround and move it to the grandpa package in the future.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GHOST method identifies the "heaviest" block -> the block with the most cumulative votes, from the current voting round. The implementation ensures that the block selection adheres to the threshold of valid votes, recursively including ancestor blocks when direct votes are insufficient.
Fixes #395