-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom JEXL functions #504
base: master
Are you sure you want to change the base?
Add custom JEXL functions #504
Conversation
…for JEXL engine Signed-off-by: David Murch <david.murch@integration.works>
… instance var Signed-off-by: David Murch <david.murch@integration.works>
57b27fd
to
074a8a1
Compare
Thanks very much @davidmurch for working on this. Two things I think would be good:
|
@davidmurch and I are working on this project together - Test case will be there sometime today (NZ time) |
It's not just GeneralUtils functions that can be put into variables in JEXL expressions Added CustomFunctionsTest - to make sure we can add customFunctions into variables in JEXL expressions Renamed test/java/.../hl7/expression/varable directory to variable Added License SPDX header and Copyright to Te Whatu Ora Signed-off-by: Stuart McGrigor <stuart.mcgrigor@midcentraldhb.govt.nz> # Conflicts: # src/main/java/io/github/linuxforhealth/hl7/message/HL7MessageData.java Signed-off-by: David Murch <david.murch@integration.works>
@davidmurch @stueynz I see you had another commit, please tag when you are ready for a review |
@davidmurch @stueynz I see no activity here; do you still want to pursue? |
Apologies for the delays as we completed our project using hl7v2-fhir-converter. I need to add our docs/examples etc and will update. |
Issue logged here #503
I believe this is minimum change needed to add this capability. The implementer needs to create their own Engine extending
HL7MessageEngine
here is an exampleThe role of the custom Engine is just to intercept the
transform
so the new constructor on HL7MessageData can be called.Then when calling the converter supply your Engine.