English Translation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijevlam
commented
Nov 25, 2022
tijevlam
commented
- Because iI like this setup to easily practice basic regex I wanted to make it available for my non-spanish speaking teammates. And thus, I included an English translation for all game related parts. On a level basis this would be easily extended to other languages too. For the UI-texts, the setup isnt ideal for multi-languages. It might need a seperate i18n setup.
- The language selector is available in the footer. This could be a selector with flags in the future.
- The chosen language is stored in localStorage to return in its same state when you return later.
- Because iI like this setup to easily practice basic regex I wanted to make it available for my non-spanish speaking teammates. And thus, I included an English translation for all game related parts. On a level basis this would be easily extended to other languages too. For the UI-texts, the setup isnt ideal for multi-languages. It might need a seperate i18n setup. - The language selector is available in the footer. This could be a selector with flags in the future. - The chosen language is stored in localStorage to return in its same state when you return later.
|
@ManzDev its been quite some time... could you take a look at this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.