Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg-cdc old syntax: Fix test failure #30996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 10, 2025

Follow-up to #30807

Seen in https://buildkite.com/materialize/nightly/builds/10822#01944f9a-9738-4aa8-a012-bc111a2660ae

@petrosagg Is this expected? Feels like it could also be a bug since we can now still ingest a value after having dropped the column.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from petrosagg January 10, 2025 11:52
@def- def- force-pushed the pr-pg-cdc-old-fix branch from a9c074f to d031421 Compare January 10, 2025 22:43
@def- def- enabled auto-merge January 11, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant