Doc code another round of tiny changes 2 #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the documentation. * fix the issue in the documentation generation that prevents symbols with the same name and different contexts be loaded. * filter top-level modules in collecting chapters
rocky
reviewed
Feb 7, 2024
mathics/doc/common_doc.py
Outdated
| def filter_toplevel_modules(module_list): | ||
| """ | ||
| Keep just the modules at the top level. | ||
| Keep just the modules at the top level |
There was a problem hiding this comment.
Why was the "." removed? Other sentences in comments have periods, and sentences in general have periods.
Remove `want_sorting` parameter. This was added when we had a bug in
Mathics3 regarding not resetting decimal digits listing precision in a
LRU caching.
Also perform some linting:
* remove unused import
* Reinstate "." at the end of a sentence
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #990 by moving the inner loop that loads chapters in
MathicsMainDocumentation.doc_partto a new methodMathicsMainDocumentation.doc_chapter. With this change, the "on the fly" loading of documentation for Pymathics modules loaded in a Django session now is possible (and is implemented in Mathics3/mathics-django#201)