Merge pull request #272 from MeasureAuthoringTool/feature/mat-7961-tr…

…im-ecqm-abbr-title-in-filenames MAT-7961: Trim the eCQM Abbr Title when used in an export filename.
MeasureAuthoringTool · Dec 17, 2024 · c4cbd58 · c4cbd58
2 parents 70ffde2 + 702e8db
commit c4cbd58
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/main/java/gov/cms/madie/madiefhirservice/utils/ExportFileNamesUtil.java b/src/main/java/gov/cms/madie/madiefhirservice/utils/ExportFileNamesUtil.java
@@ -8,9 +8,9 @@ public class ExportFileNamesUtil {
 
   public static String getExportFileName(Measure measure) {
     if (measure.getModel().startsWith("QI-Core")) {
-      return measure.getEcqmTitle() + "-v" + measure.getVersion() + "-FHIR";
+      return measure.getEcqmTitle().trim() + "-v" + measure.getVersion() + "-FHIR";
     }
-    return measure.getEcqmTitle() + "-v" + measure.getVersion() + "-" + measure.getModel();
+    return measure.getEcqmTitle().trim() + "-v" + measure.getVersion() + "-" + measure.getModel();
   }
 
   public static String getTestCaseExportFileName(Measure measure, TestCase testCase) {

diff --git a/src/test/java/gov/cms/madie/madiefhirservice/utils/ExportFileNamesUtilTest.java b/src/test/java/gov/cms/madie/madiefhirservice/utils/ExportFileNamesUtilTest.java
@@ -1,5 +1,6 @@
 package gov.cms.madie.madiefhirservice.utils;
 
+import gov.cms.madie.models.common.ModelType;
 import gov.cms.madie.models.common.Version;
 import gov.cms.madie.models.measure.Measure;
 import gov.cms.madie.models.measure.TestCase;
@@ -18,10 +19,21 @@ public class ExportFileNamesUtilTest {
 
   @BeforeEach
   void setup() {
-    measure = Measure.builder().ecqmTitle("ecqm").version(Version.parse("1.0.000")).build();
+    measure =
+        Measure.builder()
+            .model(ModelType.QI_CORE.getValue())
+            .ecqmTitle("ecqm")
+            .version(Version.parse("1.0.000"))
+            .build();
     testCase = TestCase.builder().patientId(uuid).series("group").title("test").build();
   }
 
+  @Test
+  void trimMeasureFileName() {
+    Measure msr = measure.toBuilder().ecqmTitle("   ecqm   ").build();
+    assertEquals("ecqm-v1.0.000-FHIR", ExportFileNamesUtil.getExportFileName(msr));
+  }
+
   @Test
   void getTestCaseExportFileNameTest() {
     assertEquals(