fix(cli): don't use lambda for default #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using callable in option default has a particular meaning for click. I though it only lazy loads the default, but it has a special meaning for Click call Dynamic Default, it overrides the value passed in the cli arguments. This changes remove them. Change-Id: I4996045c7e7de4eb6b72b967601751918a61cb52
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
jd
approved these changes
Nov 27, 2024
mergify
bot
deleted the
devs/sileht/build-sys-new/I4996045c7e7de4eb6b72b967601751918a61cb52
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using callable in option default has a particular meaning for click.
I though it only lazy loads the default, but it has a special meaning
for Click call Dynamic Default, it overrides the value passed in the cli
arguments.
This changes remove them.