fix: 'Connection Request Complete' analytics event not firing

[wenfix]

Description

While investigating https://github.com/MetaMask/MetaMask-planning/issues/5627 I came across this issue: the Connect Request Completed analytics event is not being triggered. This is due to getAddressAccountType helper not supporting CAIP account ids, which throws an error that ends up failing silently. This PR fixes thats.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: dapp connection

  Scenario: user connects to a dapp
    Given modal to confirm a dapp connection

    When user confirms the connection
    Then the analytics event `Connection Request Complete` should fire

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cc6cc00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8365d30-895e-4f8d-b722-025fd7ae9cbe

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[adonesky1]

LGTM!