Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#91] 캐러셀 라우팅 및 자잘한 변경 #101

Merged
merged 28 commits into from
Jan 16, 2024

Conversation

namdaeun
Copy link
Member

@namdaeun namdaeun commented Jan 14, 2024

✨ 해당 이슈 번호 ✨

closed #91

todo

  • 캐러셀 라우팅 구현
  • 로그인 로그아웃 라우팅
  • 글감추천 width 정리
  • 인터페이스 수정

📌 내가 알게 된 부분

  • 인터페이스 재설정
export interface groupPostTypes {
  topicName: string;
  imageUrl: string;
  postTitle: string;
  postContent: string;
}

interface groupPropTypes {
  moimId: number;
  moimName: string;
  moimPosts: groupPostTypes[];
}

interface getGroupContentResponseTypes {
  status: number;
  message: string;
  data: {
    moim: groupPropTypes[];
  };
}

📌 질문할 부분

📌스크린샷(선택)

@namdaeun namdaeun added ✨ Feature 새로운 기능 추가 (새로운 구현) ⚒️ Fix 기존의 버그 수정 다은 labels Jan 14, 2024
@namdaeun namdaeun self-assigned this Jan 14, 2024
@namdaeun namdaeun changed the title [Feat/#91] 캐러셀 라우팅 구현 및 자잘한 변경 [Feat/#91] 캐러셀 라우팅 및 자잘한 변경 Jan 14, 2024
@github-actions github-actions bot added the size/m size/m label Jan 14, 2024
@ljh0608
Copy link
Member

ljh0608 commented Jan 16, 2024

커밋을 잘 나누고 있어서 흐름 파악하기 아주 좋네요. 다만 스타일만 변경한 부분은 fix말고 style 커밋메세지 사용해주세요!

Copy link
Contributor

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@moondda moondda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤더 네이밍만 수정하고 머지해주세요

Comment on lines 28 to 32
export const LogOutHeader = () => {
const navigate = useNavigate();
const handleLogIn = () => {
navigate(`/login`);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3]
헤더네이밍이 unAuthorizationHeader 면 좋을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하겠습니다!

@ljh0608 ljh0608 merged commit b50dcbc into develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가 (새로운 구현) ⚒️ Fix 기존의 버그 수정 size/m size/m 다은
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feat ] 버튼 라우팅 구현
4 participants