Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Feat/#105 ] 글모임별 글감 카테고리 API GET #106

Merged
merged 8 commits into from
Jan 16, 2024
Merged

[ Feat/#105 ] 글모임별 글감 카테고리 API GET #106

merged 8 commits into from
Jan 16, 2024

Conversation

moondda
Copy link
Contributor

@moondda moondda commented Jan 15, 2024 •
edited
Loading

✨ 해당 이슈 번호 ✨

closed #105

todo

  • 글모임별 글감 카테고리 API GET
  • 캐러셀 마진 조정 ( 왼쪽 정렬 )

해야하는 것

  • 데이터 많으면 화살표 뜨는지 확인
  • 양 옆 그라데이션 데이터 적으면 안 뜨게

데이터 채워지면 확인해볼게욥

📌 내가 알게 된 부분

📌 질문할 부분

  • 제 캐러셀이 또 다은이 캐러셀로 덮여진게 하나 있더라고요...? 그래서 마지막 커밋에서
.main .slick-track {
  position: relative;
  top: 0;
  left: 0;

  display: block;
  margin-left: auto;
  margin-right: auto;
}

여기 부분 class main 부여했습니다!!

📌스크린샷(선택)

카테고리 1개일때
Screenshot 2024-01-15 at 5 01 14 PM

카테고리 3개일때
Screenshot 2024-01-15 at 5 01 30 PM

@moondda moondda added ✨ Feature 새로운 기능 추가 (새로운 구현) 다현 labels Jan 15, 2024
@moondda moondda self-assigned this Jan 15, 2024
@github-actions github-actions bot added the size/s size/s label Jan 15, 2024
namdaeun
namdaeun approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pages/groupFeed/carousel/Carousel.tsx
@@ -18,10 +18,11 @@ import NextBtnHover from '../../../assets/svgs/groupTabNextBtnHover.svg';
interface CategoryIdPropTypes {
activeCategoryId: number;
setActiveCategoryId: Dispatch<SetStateAction<number>>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P4] 여기서 Dispatch 사용하는 이유가 궁금해요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setState의 타입이에용!

src/pages/main/style/slick.css
@@ -43,7 +43,7 @@
transform: translate3d(0, 0, 0);
}

.slick-track {
.main .slick-track {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯귯

se0jinYoon
se0jinYoon approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ljh0608
ljh0608 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljh0608 ljh0608 merged commit d8a6346 into develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se0jinYoon se0jinYoon se0jinYoon approved these changes

@namdaeun namdaeun namdaeun approved these changes

@ljh0608 ljh0608 ljh0608 approved these changes

Assignees

@moondda moondda

Labels
✨ Feature 새로운 기능 추가 (새로운 구현) size/s size/s 다현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ feat ] 글모임별 글감 카테고리 API GET
4 participants
@moondda @ljh0608 @namdaeun @se0jinYoon