Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#95] 에디터 이미지 업로드 구현 및 에디터 뷰 퍼블리싱 합치기 #110

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

se0jinYoon
Copy link
Contributor

@se0jinYoon se0jinYoon commented Jan 16, 2024

✨ 해당 이슈 번호 ✨

closes #95

todo

  • 에디터 이미지 업로드 함수 구현
  • 에디터 뷰 전체 퍼블리싱 취합
  • 헤더 alert창 구현
  • 에디터 svg 변경 완료 (마진값 조절 필요)

📌 내가 알게 된 부분

📌 질문할 부분

📌스크린샷(선택)

기본 뷰

스크린샷 2024-01-16 오후 5 02 25

이미지 업로드

스크린샷 2024-01-16 오후 5 02 28 스크린샷 2024-01-16 오후 5 02 34

헤더 alert창 구현

스크린샷 2024-01-16 오후 5 02 43 스크린샷 2024-01-16 오후 5 02 38

@se0jinYoon se0jinYoon added ✨ Feature 새로운 기능 추가 (새로운 구현) 서진 labels Jan 16, 2024
@se0jinYoon se0jinYoon self-assigned this Jan 16, 2024
@github-actions github-actions bot added the size/l size/l label Jan 16, 2024
Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -20,15 +20,13 @@ const DropDown = () => {
writer: '작자미상',
});

const dropDownRef = useRef(null);

// 드롭다운 리스트 중 선택된 값 저장 이벤트 핸들러
const handleListItem = (key: string, value: string) => {
setSelectedValues((prev) => ({ ...prev, [key]: value }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P5] 스프레드 연산자를 이렇게 이용할 수 있군요 배워갑니다✨

width: 100%;
height: 30.7rem;
object-fit: cover; //픽스
background-color: #e4f4b5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 수정해주세욤

`;

const EditorThuminputIcnActiveIcon = styled(EditorThuminputIcnActiveIc)`
margin-left: 69%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

퍼센트로 마진값을 잡으신 이유가 뭔가요??

Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljh0608 ljh0608 merged commit c307177 into develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가 (새로운 구현) size/l size/l 서진
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ Feat ] 에디터 뷰 이미지 업로드 퍼블리싱
4 participants