Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#102] curious api #112

Merged
merged 6 commits into from
Jan 16, 2024
Merged

[Feat/#102] curious api #112

merged 6 commits into from
Jan 16, 2024

Conversation

ljh0608
Copy link
Member

@ljh0608 ljh0608 commented Jan 16, 2024

✨ 해당 이슈 번호 ✨

closes #102

todo

  • 궁금해요 생성 api연결
  • 로그인 api 반복 요청 에러 useEffect로 수정

📌 내가 알게 된 부분

  • useEffect를 사용하지 않으면 페이지에 post요청이 무한으로 발생한다.

📌 질문할 부분

📌스크린샷(선택)

서버 500으로 스크린샷 없음

@ljh0608 ljh0608 added ✨ Feature 새로운 기능 추가 (새로운 구현) 재훈 labels Jan 16, 2024
@ljh0608 ljh0608 self-assigned this Jan 16, 2024
@github-actions github-actions bot added the size/m size/m label Jan 16, 2024
Copy link
Contributor

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


// }
const handleIsClick = () => {
const { mutate: postCurious } = usePostCurious(postId || '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) 여기서 mutate가 뭐 하는 거에요 ?

setIsClick((prev) => !prev);
postCurious();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) mutate로 불러와서 사용하는 거 아닌가요..?... ?

Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@moondda moondda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +3 to +4
export { default as EditorHorizonIcnUnactiveSvg } from './editorHorizonIcnUnactive.svg?react';
export { default as EditorTextColorIcnBlackSvg } from './editorTextcolorIcnBlack.svg?react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2) 네이밍컨벤션 지켜주세요~

@ljh0608 ljh0608 merged commit 55f6a08 into develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가 (새로운 구현) size/m size/m 재훈
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ Feat ] 궁금해요 생성, 삭제 api연결
4 participants