[Feat/#133] 로그인 로그아웃 라우팅 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljh0608
approved these changes
Jan 17, 2024
| @@ -17,7 +17,7 @@ import Spacing from './../../components/commons/Spacing'; | |||
| const Main = () => { | |||
| return ( | |||
| <MainPageWrapper> | |||
| <MainHeader /> | |||
| {localStorage.getItem('accessToken') === null ? <UnAuthorizationHeader /> : <LogInHeader />} | |||
There was a problem hiding this comment.
[P3] LoginHeader라는 컴포넌트명은 혼동이 있을 수 있으니 AuthorizationHeader 로 변경해주실 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
closed #133
todo
📌 내가 알게 된 부분
🔴 로컬 스토리지에 토큰이 없으면 로그인 헤더 띄우고, 있으면 로그아웃 있는 헤더 띄우기 → 로컬 스토리지에 토큰이 있는지 없는지 어떻게 알지?
🟢
localStorage.getItem을 사용해서 토큰이 존재하는지 여부 확인!📌 질문할 부분
location.reload()를 사용해서 리로드했는데, 이렇게되면 페이지 전체가 리로드 돼서 .. 성능 최적화를 위해 해당 컴포넌트(헤더)만 리로드 되는 방법을 아직 찾고 있습니다..! (Fix로 브랜치 다시 팠습니다)📌스크린샷(선택)
2024-01-17.8.51.55.mov