[Init/#20] theme, GlobalStyle 세팅 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljh0608
requested changes
Jan 7, 2024
src/styles/global.style.ts
Outdated
| import { css } from '@emotion/react'; | ||
|
|
||
| const globalStyle = css` | ||
| html, |
There was a problem hiding this comment.
[P2]
* {
box-sizing: border-box;
font-family: "Pretendard Variable", Pretendard, -apple-system, BlinkMacSystemFont, system-ui, Roboto, "Helvetica Neue", "Segoe UI", "Apple SD Gothic Neo", "Noto Sans KR", "Malgun Gothic", "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", sans-serif;
}
html, body {
margin: 0 auto;
font-size: 62.5%;
}
a {
cursor: pointer;
text-decoration: none;
color:inherit;
}
button {
border: none;
background: none;
cursor: pointer;
font: inherit;
}
select{
cursor: pointer;
}
`;
위와 같이 버튼에는 pointer와 border none 등 글로벌 스타일로 지정해주세요! 제가 노션에 남겨놨었는데 내일 확인 바랍니다~
| mileGreen: '#C5DB8F', | ||
| lightGreen: '#F1F6E2', | ||
| backGround: '#F5F5F7', | ||
| black: '#010101', |
There was a problem hiding this comment.
[P3] backGround는 backgroundGray 처럼 의미가 잘 전달되는 이름을 사용하면 좋을 것 같아요!
There was a problem hiding this comment.
동의합니다 변수명 생각해보고 디자인 선생님분들께 문의 드려볼게요!
Comment on lines
+30
to
+33
| title1: SerializedStyles; | ||
| title2: SerializedStyles; | ||
| title3: SerializedStyles; | ||
| title4: SerializedStyles; |
src/styles/GlobalStyle.tsx
Outdated
Comment on lines
3
to
4
| const reset = css` | ||
| * { |
There was a problem hiding this comment.
[P2] 이름을 globalStyle 로 변수명을 바꾸고 이 안에 reset을 선언해준 다음에 이걸 글로벌 스타일로 사용해야합니다!
se0jinYoon
approved these changes
Jan 7, 2024
src/main.tsx
Outdated
| @@ -1,13 +1,15 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import { ThemeProvider } from '@emotion/react'; | |||
| import { Global, ThemeProvider } from '@emotion/react'; | |||
| import reset from 'emotion-reset'; | |||
Comment on lines
+30
to
+33
| title1: SerializedStyles; | ||
| title2: SerializedStyles; | ||
| title3: SerializedStyles; | ||
| title4: SerializedStyles; |
ljh0608
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
�closed #20
todo
📌 내가 알게 된 부분
트러블 슈팅
📌 질문할 부분
📌스크린샷(선택)