[ Feat/#481] 그룹 생성페이지 플로우 반응형 전환 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ljh0608
changed the title
namdaeun
approved these changes
Dec 5, 2024
| @@ -255,6 +257,11 @@ const BtnWrapper = styled.div` | |||
| flex-direction: column; | |||
| gap: 1.2rem; | |||
| width: 82.6rem; | |||
|
|
|||
| @media ${MOBILE_MEDIA_QUERY} { | |||
| flex-direction: row-reverse; | |||
There was a problem hiding this comment.
P5) 오호 이 속성 사용하는 건 처음 보는데 이런식으로 배치를 적용해줄 수 있겠군요 👍🏻
| @@ -192,7 +187,7 @@ const CreateGroupInfo = ({ | |||
| <Spacing marginBottom="2.4" /> | |||
| <picture> | |||
| <source srcSet={createGroupWebp} /> | |||
| <img src={createGroupIlust} /> | |||
| <GroupImage src={createGroupIlust} /> | |||
There was a problem hiding this comment.
P1) alt 속성으로 어떤 이미지인지에 대한 설명도 추가해주면 좋을 것 같아요 !
| isValid={leaderPenName.length <= 8} | ||
| onChange={(e) => handleLeaderNameInput(e)} | ||
| maxLength={9} | ||
| />{' '} |
se0jinYoon
approved these changes
Dec 6, 2024
| @@ -403,13 +431,16 @@ const GroupInfoWrppaer = styled.section` | |||
| `; | |||
|
|
|||
| const TextAreaLength = styled.p<{ isValid: boolean }>` | |||
| position: relative; | |||
| position: absolute; | |||
| right: 45px; | |||
There was a problem hiding this comment.
p1) 이거 px로 되어있는 이유가 뭔가요?
| bottom: 4rem; | ||
| left: 70.6rem; | ||
|
|
||
| /* left: 70.6rem; */ |
Comment on lines
1
to
8
| export const InputInfoMsg = { | ||
| groupNameLength: '10자 이내로 작성해주세요.', | ||
| groupNameNotAvailable: '이미 사용중인 모임명입니다.', | ||
| groupNameNotCheck: '중복확인을 해주세요.', | ||
| groupNameAvailable: '사용 가능한 모임명입니다.', | ||
| groupNameEmpty: '글모임 이름을 입력해주세요.', | ||
| emptyText: '', | ||
| }; |
There was a problem hiding this comment.
p5) const니까 대문자로 export해도 좋을 것 같아용
| padding: 6.4rem 0; | ||
| width: 100%; | ||
|
|
||
| /* height: calc(100% - 44px); */ |
…into feat/#481/responsiveWebCreateGroupPage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
#481
todo
📌 내가 알게 된 부분
📌 질문할 부분
📌스크린샷(선택)