[Feat/#47] Main 페이지 캐러셀 구현 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0417ac6.
se0jinYoon
approved these changes
Jan 11, 2024
Comment on lines
+52
to
+58
| isImage && isLast | ||
| ? '47.8rem' | ||
| : isImage && !isLast | ||
| ? '59.8rem' | ||
| : !isImage && isLast | ||
| ? '68.2rem' | ||
| : '85.8rem'}; |
| ${({ theme }) => theme.fonts.body3}; | ||
| `; | ||
|
|
||
| const Image = styled.img<{ isLast: boolean }>` |
ljh0608
approved these changes
Jan 11, 2024
|
|
||
| export default Carousel; | ||
|
|
||
| const CarouselContentWithSummaryWrapper = styled.div``; |
There was a problem hiding this comment.
[ P3 ] 이렇게 돔을 하나더 추가할 필요 없이
<></> fragment 사용하면 좋아요 이건 dom에 추가안돼서 지금처럼 스타일 없는 div를 추가할 필요 없습니다!
https://react.dev/reference/react/Fragment
| {subtext} | ||
| </SubText> | ||
| </TextContainer> | ||
| {image && <Image src={image} isLast={isLast} alt="group-content-image" />} |
There was a problem hiding this comment.
[P5] alt 적용해서 시맨틱하게 코드짜는거 배워갑니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
closed #47
todo
📌 내가 알게 된 부분
📌 질문할 부분
📌스크린샷(선택)
2024-01-11.8.38.34.mov
2024-01-11.8.32.38.mov