[Feat/#83] 오늘의 글감 API GET #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se0jinYoon
approved these changes
Jan 14, 2024
| @@ -11,11 +16,29 @@ interface GroupFeedAuthQueryResult { | |||
|
|
|||
| export const useGroupFeedAuth = (groupId: string): GroupFeedAuthQueryResult => { | |||
| const { data, isLoading, isError, error } = useQuery({ | |||
| queryKey: ['groupFeed_Auth_moimId', groupId], | |||
| queryKey: [QUERY_KEY_GROUPFEED.getGroupFeedAuth, groupId], | |||
| queryFn: () => fetchTodayWritingStyle(groupId), | ||
| }); | ||
|
|
||
| const content = data && data.data.content; |
ljh0608
approved these changes
Jan 14, 2024
| import Button from '../../../components/commons/Button'; | ||
|
|
||
| interface GroupTodayWriteStylePropTypes { | ||
| isMember: boolean; | ||
| isMember: boolean; //나의 글 작성하기 권한 확인 | ||
| groupId: string | undefined; //오늘의 주제 |
There was a problem hiding this comment.
[P1] 오늘의 주제인지 groupId인지 잘 모르겠는데 undefined가 올 수 있는지 string이 맞는지 한 번 체크 부탁드려요!
ljh0608
approved these changes
Jan 14, 2024
| } | ||
|
|
||
| const GroupTodayWriteStyle = (props: GroupTodayWriteStylePropTypes) => { | ||
| const { isMember } = props; | ||
| const { isMember, groupId } = props; | ||
| const { content, isLoading, isError, error } = useTodayWritingStyle(groupId || ''); |
There was a problem hiding this comment.
[P2] Topic으로 네이밍 가독성 좋게 해주시면 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
closed #83
todo
📌 내가 알게 된 부분
📌 질문할 부분
📌스크린샷(선택)