-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies and add CI #2
Conversation
WalkthroughThis update introduces a new GitHub Actions workflow for automated testing, modifies the README for clarity on licensing, and updates the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/test.yml (1 hunks)
- README.md (1 hunks)
- deno.jsonc (1 hunks)
- denops/@ddu-filters/matcher_kensaku.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Additional comments not posted (11)
deno.jsonc (4)
3-6
: LGTM! Excluding markdown files from formatting.The addition of the "fmt" section to exclude markdown files from formatting is appropriate.
9-9
: LGTM! Combining linting and formatting checks.The modification to combine linting and formatting checks in the "check" task improves clarity and functionality.
10-10
: LGTM! Streamlining the testing task.The modification to the "test" task by removing the
--no-lock
option may streamline testing.
11-11
: LGTM! Enhancing the update task.The renaming of the "upgrade" task to "update" and the inclusion of additional permissions and options enhance the update mechanism.
.github/workflows/test.yml (5)
1-1
: LGTM! Naming the workflow "Test".The workflow name "Test" is appropriate and clear.
3-12
: LGTM! Defining appropriate trigger events.The workflow is triggered on push to master and pull requests affecting specific files, ensuring relevant changes are tested.
14-16
: LGTM! Setting the default shell.The default shell is set to bash with specific options, which is appropriate for the workflow.
18-26
: LGTM! Defining the job strategy.The job strategy defines a matrix with runner and Deno version, ensuring the workflow is tested across different environments.
27-35
: LGTM! Defining the workflow steps.The steps include checking out the code, setting up Deno, and running the check task, ensuring the workflow functions correctly.
denops/@ddu-filters/matcher_kensaku.ts (2)
1-5
: LGTM! Updating type imports to a newer version.The type imports are updated to use a newer version of the Ddu library, which likely includes improvements or modifications to the types being used.
6-10
: LGTM! Updating type imports to a newer version.The type imports are updated to use a newer version of the Ddu library, which likely includes improvements or modifications to the types being used.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Refactor