fix: :art: implement requested changes for stop challenge cycle PR · Moonsong-Labs/storage-hub@4ff623b

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/randomness/src/benchmarking.rs#L6

bound is defined in more than one place

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/randomness/src/lib.rs#L198

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/bucket-nfts/src/lib.rs#L56

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/providers/src/lib.rs#L1455

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/proofs-dealer/src/lib.rs#L743

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L593

useless conversion to the same type: `std::collections::btree_set::Difference<'_, <<T as pallet_proofs_dealer::Config>::ProvidersPallet as shp_traits::ReadChallengeableProvidersInterface>::ProviderId>`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L643

called `expect` on `providers_to_mark` after checking its variant with `is_some`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L576

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/payment-streams/src/lib.rs#L413

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/file-system/src/utils.rs#L71

the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 🎨 implement requested changes for stop challenge cycle PR #2443

Check lint with clippy

fix: 🎨 implement requested changes for stop challenge cycle PR #2443

Jobs

Run details

Annotations

Check lint with clippy

Re-running jobs...