-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ remove file deletion requests expiration #311
base: main
Are you sure you want to change the base?
Conversation
…deletion-requests-expiration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love seeing all the deleted complexity
…deletion-requests-expiration
…deletion-requests-expiration
…deletion-requests-expiration
…deletion-requests-expiration
@TDemeco Regarding the soundness of incentives to prevent spamming with file deletions, I can think of two mitigations:
|
I second this approach
|
This PR makes it so file deletion requests no longer expire. This is possible since MSPs are now incentivized to submit the required proofs to close the pending file deletion requests because they are removed from the privileged providers in the meantime, so they can't charge any users.
This PR should be merged after #310
TODO list: