Fix for "none" units edge case #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peverwhee
requested review from
climbfuji,
gold2718,
dustinswales,
mwaxmonsky,
grantfirl and
mkavulich
as code owners
climbfuji
approved these changes
Aug 5, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
mwaxmonsky
approved these changes
Aug 6, 2024
dustinswales
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny bugfix for unit conversion edge case that was trying to convert "None" to "none"
Description
Convert "none" units to lowercase before comparing.
User interface changes?: No
Fixes:
closes #567
Testing: