Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how the base_sha is passed into the workflow #81

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 3, 2025

Description

  • Fixes CI for non-PR workflows

Closes #80

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 3, 2025
@dagardner-nv dagardner-nv self-assigned this Apr 3, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner April 3, 2025 21:07
@AnuradhaKaruppiah
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2025f95 into NVIDIA:develop Apr 7, 2025
10 checks passed
@dagardner-nv dagardner-nv deleted the david-ci-dev-failing-80 branch April 7, 2025 15:13
liamy-nv pushed a commit to liamy-nv/AgentIQ that referenced this pull request Apr 9, 2025
* Fixes CI for non-PR workflows

Closes NVIDIA#80

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: CI failing on a template error when run from the develop branch
2 participants