Pod-group-controller env tests #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds infrastructure to test the PodGroupController in env-tests and includes a basic sanity test demonstrating the functionality.
Key Changes
- Created test infrastructure for running PodGroupController in test environments
- Added binder integration for complete pod lifecycle testing
- Implemented a sanity test that verifies PodGroup status updates when pods are bound
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/env-tests/podgroupcontroller_test.go | New test file with PodGroupController test infrastructure and sanity test |
| pkg/env-tests/podgroupcontroller/podgroupcontroller.go | New helper module to run PodGroupController in test context |
| pkg/env-tests/binder/binder.go | Updated binder helper to accept configurable flag sets |
| pkg/env-tests/scheduler_test.go | Removed empty line formatting issue |
| pkg/binder/controllers/*.go | Added SkipNameValidation configuration for test compatibility |
| cmd/podgroupcontroller/main.go | Refactored main function to support programmatic execution |
| cmd/podgroupcontroller/app/*.go | Modified app structure to accept external configuration and context |
| cmd/binder/app/options.go | Made InitOptions accept optional flag set parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
itsomri
force-pushed
the
omric/podgroupcontroller-env-tests
branch
from
cf45ae8 to
857f379
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the infra to test the podgroupcontroller in env-tests. Added one sanity test as example.