feat: add data shuffle option #334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
SahilJain314
reviewed
May 8, 2025
| @@ -153,7 +153,7 @@ def setup( | |||
| train_dataloader = StatefulDataLoader( | |||
| train_dataset, | |||
| batch_size=policy_config["train_global_batch_size"], | |||
| shuffle=True, | |||
| shuffle=data_config["shuffle"], | |||
There was a problem hiding this comment.
Can we add seeding if we're shuffling? I don't want subsequent runs to randomly repeat data.
There was a problem hiding this comment.
Good point. Is that a good idea to set global random seed like
https://github.com/huggingface/transformers/blob/v4.51.3/src/transformers/trainer_utils.py#L92-L125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information