-
Notifications
You must be signed in to change notification settings - Fork 417
[PyTorch] Refactor activation offloading of quantized tensors. #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pggPL
wants to merge
17
commits into
NVIDIA:main
Choose a base branch
from
pggPL:quantized_tensor_offloading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
bbf24cd
to
657cbbe
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
/te-ci pytorch |
/te-ci pytorch |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
/te-ci pytorch |
32f982b
to
4293d32
Compare
/te-ci pytorch |
7a6b62d
to
da1bbf9
Compare
/te-ci pytorch |
1 similar comment
/te-ci pytorch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code of activation offloading has some complex logic handling offloading Float8Tensor object - it disassembles the object into the data tensors, then offloads them separately and then assembles them.
I add
empty_like(..., device=..., pin_memory=...)
method to Float8Tensor, which allow easy CPU backup tensor allocation. This allows me to make the code of the offloading much simpler.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: