Fix null pointer reference issue with cuda driver API function pointer… #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in case cuInit fails
|
updates |
…KED_CALL macro which returned prematurely
NianZo
reviewed
Aug 5, 2025
NianZo
reviewed
Aug 5, 2025
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
… with error in case of LOADLIBRARY failureas initialize of function pointers in case of LOADLIBRARY failure will fail
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
Samples/0_Introduction/matrixMulDynlinkJIT/cuda_drvapi_dynlink.c
Outdated
Show resolved
Hide resolved
ntalpallikar
changed the title
|
Thanks for submitting this pull request! Functionally looks good, but whitespace and code formatting are not correct for this repository's style guidelines. Can you please run |
fixed |
|
Looks good, thanks for your submission. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see app crash when CuInit returns failure before initializing all the function pointers. Error path should not crash. PR for failsafe error path.