Skip to content

Commit

Permalink
Merge branch 'main' into chore/update-dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
nnansters committed Dec 18, 2024
2 parents 9de66dc + c6d326e commit a8ac374
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions nannyml/drift/univariate/calculator.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ def __init__(
{
'kolmogorov_smirnov': StandardDeviationThreshold(std_lower_multiplier=None),
'jensen_shannon': ConstantThreshold(upper=0.1),
'jensen_shannon': StandardDeviationThreshold(std_lower_multiplier=None),
'wasserstein': StandardDeviationThreshold(std_lower_multiplier=None),
'hellinger': ConstantThreshold(upper=0.1),
'l_infinity': ConstantThreshold(upper=0.1)
'hellinger': StandardDeviationThreshold(std_lower_multiplier=None),
'l_infinity': StandardDeviationThreshold(std_lower_multiplier=None),
}
A dictionary allowing users to set a custom threshold for each method. It links a `Threshold` subclass
Expand All @@ -130,10 +130,10 @@ def __init__(
will be applied. The default method thresholds are as follows:
- `kolmogorov_smirnov`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `jensen_shannon`: `ConstantThreshold(upper=0.1)`
- `jensen_shannon`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `wasserstein`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `hellinger`: `ConstantThreshold(upper=0.1)`
- `l_infinity`: `ConstantThreshold(upper=0.1)`
- `hellinger`: `StandardDeviationThreshold(std_lower_multiplier=None)`
- `l_infinity`: `StandardDeviationThreshold(std_lower_multiplier=None)`
The `chi2` method does not support custom thresholds for now. Additional research is required to determine
how to transition from its current p-value based implementation.
Expand Down

0 comments on commit a8ac374

Please sign in to comment.