Optimize filtering univariate result for period #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PerMetricPerColumnResult` filter function has a high overhead for selecting a subset of columns or metrics. This overhead is also incurred (and highest) when only filtering for period, as then all columns & metrics will be selected. This commit adds a short-circuit path to avoid the overhead when only the period requires filtering. For a result with 50 columns and 8 metrics this results in a >100x speed-up when only filtering for period.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 110 110
Lines 9242 9244 +2
Branches 1658 1659 +1
=======================================
+ Hits 7072 7074 +2
Misses 1703 1703
Partials 467 467 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PerMetricPerColumnResultfilter function has a high overhead for selecting a subset of columns or metrics. This overhead is also incurred (and highest) when only filtering for period, as then all columns & metrics will be selected.This commit adds a short-circuit path to avoid the overhead when only the period requires filtering. For a result with 50 columns and 8 metrics this results in a >100x speed-up when only filtering for period.