Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle older assay IDs #185

Open
andrewrech opened this issue Apr 26, 2023 · 5 comments · Fixed by #192
Open

Handle older assay IDs #185

andrewrech opened this issue Apr 26, 2023 · 5 comments · Fixed by #192

Comments

@andrewrech
Copy link

Please add the following

  # Handle older assay probe labels
  if (pkcData[["RTS_ID"]][1] %like% "^RTS" &
    probeAssay[["RTS_ID"]][1] %like% "^RNA") {
    # replace RTS00 with RNA in probeAssay[["RTS_ID"]]
    probeAssay[["RTS_ID"]] <- gsub("^RNA", "RTS00", probeAssay[["RTS_ID"]])
  }

https://github.com/andrewrech/GeomxTools/commit/d567c3590cffc1afd8387e09d55a0a3942b33780

to handle assays that use the older probe labels.

thanks

Andrew

@maddygriz
Copy link
Collaborator

Hi Andrew,

Thanks for this fix, we will consider this for the next release.
What PKC are you using so we can make sure future GeomxTools releases are fully compatible with legacy files still in use?

Maddy

@andrewrech
Copy link
Author

This is from 2021 datasetthat is used in a package test for my internal tool. The PKC file is GeoMx_Hs_CTA_v1.0.pkc, which has the newer labels. The DCC files are I think TAP program generated and have the older RNA* labels.

@maddygriz
Copy link
Collaborator

Gotcha. So older DCC files and a newer PKC file. I will add that to our internal bug so we can test the correct situation.

Thanks,
Maddy

@shaniAmare
Copy link

Has this been fixed? I get the following error when I try the Mm_R_NGS_WTA_v1.0.pkc which I'm assuming is due to incompatibility of pic file and the dcc files.

Error in data.frame(RTS_ID = pkcData[zeroProbes, "RTS_ID"], Count = rep(0,  : 
  arguments imply differing number of rows: 20175, 0

The code I'm trying is:

> dccSet <-
+     suppressWarnings(readNanoStringGeoMxSet(dccFiles = dccFiles,
+                            pkcFiles = PKCFiles,
+                            phenoDataFile = SampleAnnotationFile,
+                            phenoDataSheet = "SegmentProperties",
+                            phenoDataDccColName = "SegmentDisplayName"))

Many thanks for your time
Shani.

@maddygriz
Copy link
Collaborator

Hi @shaniAmare,

Yours might be a different issue. Our customer support team will be able to help you with this. Please email support@nanostring.com with your issue.

Thanks,
Maddy

@maddygriz maddygriz mentioned this issue Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants