Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioc3.19 #192

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Bioc3.19 #192

merged 12 commits into from
Feb 5, 2024

Conversation

maddygriz
Copy link
Collaborator

devtools::check()
image
warning = qpdf

R CMD build --keep-empty-dirs --no-resave-data GeomxTools & R CMD check
image

  • checking PDF version of manual ... WARNING
  • checking PDF version of manual without index ... ERROR

@maddygriz maddygriz changed the base branch from master to dev December 28, 2023 23:44
@maddygriz
Copy link
Collaborator Author

maddygriz commented Dec 29, 2023

IPA test data can be found at HSDATA\SABonnett\GeoMx Tools\IPA Test

devtools::check()
0 errors ✔ | 1 warning ✖ | 6 notes ✖
❯ checking for unstated dependencies in examples ... OK
WARNING
‘qpdf’ is needed for checks on size reduction of PDFs

R CMD build --keep-empty-dirs --no-resave-data GeomxTools & R CMD check
Status: 1 ERROR, 1 WARNING, 5 NOTEs

  • checking PDF version of manual ... WARNING
  • checking PDF version of manual without index ... ERROR

@maddygriz maddygriz requested a review from mgrout81 January 11, 2024 17:14
@NicoleEO
Copy link
Collaborator

NicoleEO commented Jan 17, 2024

@maddygriz there seems to be an issue with readPKC getting gene id from IPA pkc. Also, is there any chance to add RTSID to featureData as well? It was also found that the fig() function was not working, but may be related to the GeneID missing from featureData after readPKC issue.

@maddygriz
Copy link
Collaborator Author

@mgrout81 Dave H found an issue on this branch about pkc info not being added to the feature metadata correctly. I have addressed that issue.
image

@mgrout81
Copy link
Collaborator

Thanks, I will update my package accordingly.

@mgrout81
Copy link
Collaborator

mgrout81 commented Feb 2, 2024

readPKCFile() appears to be working as expected. NA values above are in negative probes.
image

@mgrout81 mgrout81 merged commit 09f3a07 into dev Feb 5, 2024
@maddygriz
Copy link
Collaborator Author

Megan approved and completed PR

@maddygriz maddygriz deleted the bioc3.19 branch February 6, 2024 17:28
@maddygriz maddygriz restored the bioc3.19 branch March 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error coercing GeoMx data to Seurat object Prepare for upcoming Seurat v5 release Handle older assay IDs
3 participants