Add is_finitely_generated for FPModules and fix is_noetherian
#2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2127 +/- ##
==========================================
+ Coverage 87.97% 88.16% +0.18%
==========================================
Files 126 126
Lines 31654 32355 +701
==========================================
+ Hits 27849 28526 +677
- Misses 3805 3829 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Jul 16, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
fingolfin
reviewed
Jul 23, 2025
Co-authored-by: Max Horn <max@quendi.de>
|
Can this be merged? |
fingolfin
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2125.
CC @fingolfin