fix(runtime): Non-standard Concatenation Algorithm in BOM URL polyfill #17472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo837
reviewed
Mar 25, 2025
| } | ||
| const { protocol, origin, pathname, href } = parsedBase | ||
|
|
||
| fullUrl = url |
There was a problem hiding this comment.
个人觉得这个不如之前的写法清晰易读
在同一份数据涉及的操作不多时，展开写可能更清晰；但分支情况多了，代码行数多反而不利于阅读，格式化规范的三目运算符则能清晰展示不同条件和分支的相互关系。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么？
修正 Taro runtime 中的 polyfill，对齐 Web URL 标准中的路径拼接算法：https://developer.mozilla.org/zh-CN/docs/Web/API/URL/URL 。
这个 PR 是什么类型？
这个 PR 涉及以下平台：