-
Notifications
You must be signed in to change notification settings - Fork 5
Add CloudWatch to ontap monitor services #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds CloudWatch support for alerting on ONTAP services, enhances volume-level inode utilization alerts, and improves EMS message filtering and matching. Key changes include replacing direct logger/sns calls with a centralized sendAlert function, refining configuration handling (including CloudWatch endpoint variables), and updating README documentation to reflect the new monitoring features and AWS endpoint requirements.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
Monitoring/monitor-ontap-services/monitor_ontap_services.py | Replaces direct alert calls with sendAlert; adds helper functions (lagTimeStr, findMatch) and updates environment variable handling for CloudWatch. |
Monitoring/monitor-ontap-services/README.md | Updates installation instructions and matching conditions documentation to include CloudWatch and revised endpoint requirements. |
Comments suppressed due to low confidence (1)
Monitoring/monitor-ontap-services/monitor_ontap_services.py:507
- [nitpick] Avoid using 'str' as a variable name since it shadows the built-in type; consider renaming it to 'timeStr' or a similar descriptive name.
str = lagTimeStr(lagSeconds)
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…xpected scheduled update.
…e (over 100%) of the last scheduled update.
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
…will be enabled by default.
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Monitoring/monitor-ontap-services/buildLambdaLayer: Language not supported
The following major changes were made: