Skip to content

Add CloudWatch to ontap monitor services #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 30, 2025
Merged

Conversation

kcantrel
Copy link
Collaborator

The following major changes were made:

  • Added CloudWatch as an optional alert destination.
  • Added an inode utilization alert at the volume level.
  • Added a "filter" parameter for EMS messages so you could explicitly filter out messages as opposed to just matching them.
  • Added a "match" and "exception" parameter for the volume utilization message so you could set up specific rules for particular volumes.
  • Updated the README to be more accurate as to when you need to add AWS service endpoints.
  • Allow you to provide an ARN for the roles so the CloudFormation template doesn't have to create them.

…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
…alert; Added an EMS filter, as well as exceptions and specific matches for volume utilization alerts.
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@kcantrel kcantrel requested a review from Copilot April 18, 2025 21:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds CloudWatch support for alerting on ONTAP services, enhances volume-level inode utilization alerts, and improves EMS message filtering and matching. Key changes include replacing direct logger/sns calls with a centralized sendAlert function, refining configuration handling (including CloudWatch endpoint variables), and updating README documentation to reflect the new monitoring features and AWS endpoint requirements.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Monitoring/monitor-ontap-services/monitor_ontap_services.py Replaces direct alert calls with sendAlert; adds helper functions (lagTimeStr, findMatch) and updates environment variable handling for CloudWatch.
Monitoring/monitor-ontap-services/README.md Updates installation instructions and matching conditions documentation to include CloudWatch and revised endpoint requirements.
Comments suppressed due to low confidence (1)

Monitoring/monitor-ontap-services/monitor_ontap_services.py:507

  • [nitpick] Avoid using 'str' as a variable name since it shadows the built-in type; consider renaming it to 'timeStr' or a similar descriptive name.
str = lagTimeStr(lagSeconds)

kcantrel and others added 3 commits April 18, 2025 17:22
@kcantrel kcantrel requested a review from nichollri April 18, 2025 22:30
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
…t the matching and excptions option with volume utilization alerts, since it was causing issues with aging out events.
@kcantrel kcantrel requested a review from Copilot April 30, 2025 16:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Monitoring/monitor-ontap-services/buildLambdaLayer: Language not supported

@kcantrel kcantrel merged commit 4d74885 into main Apr 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant