Bug/forbidden #125
Merged
Bug/forbidden #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Description of the Change
403 and 404 responses were not being handled properly. The UI would show a generic error. The generic error was shown because an exception was caught when trying to parse the response as JSON. 403 and 404 responses were HTML, not JSON.
This change catches those statuses earlier and returns the appropriate error.
Alternate Designs
-
Possible Drawbacks
Some states where a 404 was not expected may show more specific error messaging.
Verification Process
Go to a page where the server will be returning a 403. You should see a specific 403 error on the screen instead of a generic error.
Release Notes
Handle 403 and 404 responses.