Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding string type as value to neurodata object properties #675

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Mar 3, 2025

Motivation

Adding string types to properties causes error on nwbExport. As the string type was introduced in R2016b, it should be supported by MatNWB.

How to test the behavior?

nwb = tests.factory.NWBFile();

generalExperimenter = ["John Doe", "Jane Doe"];
generalExperimentDescription = "Test with string data types";
nwb.general_experimenter = generalExperimenter;
nwb.general_experiment_description = generalExperimentDescription;

nwbExport(nwb, "test.nwb");

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Copy link
Collaborator Author

NB:
2 tests are failing because the Clustering neurodata type was deprecated in pynwb, but is still used in the matnwb test suite

@ehennestad ehennestad marked this pull request as ready for review March 3, 2025 19:24
@ehennestad ehennestad requested a review from bendichter March 3, 2025 19:24
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (86c3a9e) to head (be6b258).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         139      139           
  Lines        5311     5315    +4     
=======================================
+ Hits         5063     5067    +4     
  Misses        248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendichter bendichter merged commit 945fa0e into main Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants