Added Span Support to J2N.IO Buffers #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubstandard implementation. We cannot make these members abstract without a breaking change, so inheritors will need to override to optimize. Optimized Put() overload for each buffer that accepts the same type of buffer to use span overloads and to allocate using the stack or array pool to reduce GC overhead.
…he various buffers and adapters
…ertain to MemoryMappedFiles
… either StringBuilder or StringBuilderCharSequence is used.
…r for string, and optimized CharBuffer.Wrap() implemenations.
NightOwl888
added
is:enhancement
paulirwin
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for spans on the
Get()andPut()methods of the various buffers and adapters. The current implementation keeps the same calling order in the base classes (ByteBuffer,CharBuffer, etc) and each subclass overrides the implementation to provide a better optimized implementation. However, at this point the following methods are still reading one character at a time:CompareTo()Equals()GetHashCode()These will be optimized in another PR along with optimizations to the big/little endian conversions and consolidation of repetitious code.
This was discussed in apache/lucenenet#1151