Skip to content

luau-lsp: init at 1.42.1 #395892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

luau-lsp: init at 1.42.1 #395892

wants to merge 2 commits into from

Conversation

Anninzy
Copy link

@Anninzy Anninzy commented Apr 4, 2025

LSP for luau programming language
https://github.com/JohnnyMorganz/luau-lsp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 4, 2025
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Apr 4, 2025
Jappie3
Jappie3 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Jappie3 Jappie3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion, lgtm otherwise

@Jappie3
Copy link
Contributor

Jappie3 commented Apr 4, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 395892

Logs: https://github.com/Jappie3/nixpkgs-review-gha/actions/runs/14263685464

x86_64-linux

✅ 1 package built:
  • luau-lsp

aarch64-linux

✅ 1 package built:
  • luau-lsp

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 4, 2025
@Jappie3
Copy link
Contributor

Jappie3 commented Apr 4, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 395892

Logs: https://github.com/Jappie3/nixpkgs-review-gha/actions/runs/14269121715

x86_64-linux

✅ 1 package built:
  • luau-lsp

aarch64-linux

✅ 1 package built:
  • luau-lsp

Jappie3
Jappie3 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Jappie3 Jappie3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@sikmir
Copy link
Member

sikmir commented Apr 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 395892

x86_64-linux

✅ 1 package built:
  • luau-lsp

sikmir
sikmir reviewed Apr 6, 2025
View reviewed changes
pkgs/by-name/lu/luau-lsp/package.nix
};

# https://github.com/JohnnyMorganz/luau-lsp/issues/743#issuecomment-2293315812
patches = [ ./cmakelists.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

  cmakeFlags = [
    (lib.cmakeFeature "CMAKE_CXX_FLAGS_RELEASE" "-Wno-error")
  ];

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't seem to work

cmake flags: ... -DCMAKE_CXX_FLAGS_RELEASE:STRING=-Wno-error
...
cc1plus: all warnings being treated as errors

@Anninzy Anninzy changed the title luau-lsp: init at 1.42.0 luau-lsp: init at 1.42.1 Apr 7, 2025
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2025
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@Jappie3 Jappie3 Jappie3 approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anninzy @Jappie3 @sikmir @wegank @NixOSInfra