Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readest: 0.9.29 -> 0.9.30 #396313

Merged
merged 1 commit into from
Apr 8, 2025
Merged

readest: 0.9.29 -> 0.9.30 #396313

merged 1 commit into from
Apr 8, 2025
+4 −4

Conversation

ddogfoodd
Copy link
Contributor

Changelog: https://github.com/readest/readest/releases/tag/v0.9.30
Diff: readest/readest@v0.9.29...v0.9.30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Apr 5, 2025
@nix-owners nix-owners bot requested a review from eljamm April 5, 2025 12:26
@eljamm
Copy link
Contributor

eljamm commented Apr 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 396313

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14281894285

x86_64-linux

✅ 1 package built:
  • readest

aarch64-linux

✅ 1 package built:
  • readest

eljamm
eljamm approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're pretty fast with the PRs, thanks 😁

@eljamm eljamm added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 5, 2025
@ddogfoodd
Copy link
Contributor Author

You're pretty fast with the PRs, thanks 😁

You're pretty fast with the reviews, thanks as well!

@pbsbot
Copy link

pbsbot commented Apr 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396313

x86_64-linux

✅ 1 package built:
  • readest

@pbsds pbsds merged commit 33c7b87 into NixOS:master Apr 8, 2025
29 of 31 checks passed
@ddogfoodd ddogfoodd deleted the update-readest branch April 8, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljamm eljamm eljamm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddogfoodd @eljamm @pbsbot @pbsds